Fix generic parameter defaults section in Generics.md - #2986
Merged
Conversation
Jake Bailey (jakebailey)
approved these changes
Jun 2, 2024
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
I personally find this example odd due to the default being T[] (why would the children be the same type as the parent?) but that's preexisting and the PR is correct to my eye.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's suppose that
then the first
createdeclarationcorrectly catches
create(new HTMLElement(), [new Animal()])as type error, whereas the shortened version, that isdoes allow
create(new HTMLElement(), [new Animal()]).